Preview: pullrequestflow.md
Size: 1.67 KB
/var/www/bwh.wpress.dk/httpdocs/pullrequestflow.md
#Pull Request Workflow
##1. Open a pull request at the beginning of each new feature branch before writing any code
Title the PR after the JIRA ticket and the name of the feature. Assign all tech leads to the PR as Assignees. Add the label "In progress."
##2. At least once a day, push your current changes to origin, regardless of whether or not the feature is complete.
##3. Once the feature is ready for code reveiw, assign all tech leads as reviewers.
And change the label from "In progress" to "ready for review"
##Every PR must follow the below format:
**Description:**
This PR adds the new featured {{name of feature from JIRA ticket}} as described in https://bluestate.atlassian.net/browse/GEASP-18.
**Checklist:**
- The feature has been tested in all three major browsers (Safari, Firefox, and Chrome) at all breakpoints.
- The feature has passed accessibility tests.
- The feature visually matches the design comps.
- Any relevant ACF field JSONs have been exported and committed.
- The Twigs, PHP files, Javascript files and CSS files that are part of this feature have all been updated with thorough and descriptive comments.
**To Test:**
1. Ensure the ACF fields have synced.
2. The ACF fields "field one," "field two" and "field three" must be populated in the home page admin in the CMS.
**Screenshots:**
**Small breakpoint:**
<img width="568" alt="Screenshot 2022-01-12 at 4 17 04 PM" src="https://user-images.githubusercontent.com/2325801/149223027-39c4d355-809d-436e-a31f-1896103bcb3a.png">
**Large breakpoint**
<img width="1300" alt="Screenshot 2022-01-12 at 4 16 41 PM" src="https://user-images.githubusercontent.com/2325801/149223068-a7b1d6e9-4673-40ec-bb56-07d0db0f5bdd.png">
Directory Contents
Dirs: 5 × Files: 23